Make ClusterCapabilities fields optional during rollout#351
Closed
lomidzemikheili wants to merge 1 commit intomainfrom
Closed
Make ClusterCapabilities fields optional during rollout#351lomidzemikheili wants to merge 1 commit intomainfrom
lomidzemikheili wants to merge 1 commit intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
|
PR Packages Published Python Package:
NPM Package:
|
Contributor
Author
|
The required field was populated buy the service, so there is not need to make it optional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #345 / #346 introduced
ClusterState.capabilitiesand the three fields insideClusterCapabilities(disk_expansion,backup,scalability_info) with(buf.validate.field).required = true, but no producer populates them yet — so everyClusterStateresponse fails buf-validate and breaks UI calls.This relaxes those four
requiredvalidators and adds a comment that they will be tightened again once cluster-api populates the fields. The wire schema and field numbers are unchanged; only the runtime validation is loosened, so this is forward- and backward-compatible.Follow-up: populate
capabilitiesin cluster-api, then a separate PR re-introducesrequired = trueonce rollout is complete.